Correctly launch WindCharges #11418
Merged
Correctly launch WindCharges #11418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynxplay
added
the
build-pr-jar
Machine-Maker
approved these changes
Sep 21, 2024
The launch API on LivingEntity only respected the WindCharge type, not its near-clone BreezeWindCharge. This commit correctly accounts for BreezeWindCharge in CraftLivingEntity. Additionally, this also ports over the entire wind charge launch logic to BlockProjectileSource as dispensers are capable of launching wind charges.
lynxplay
force-pushed
the
bugfix/correctly-launch-wind-charges
branch
from
2326301
to
ca31085
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The launch API on LivingEntity only respected the WindCharge type, not
its near-clone BreezeWindCharge.
This commit correctly accounts for BreezeWindCharge in
CraftLivingEntity.
Resolves: #11417
Download the paperclip jar for this pull request: paper-11418.zip